fixed sampler bank file dialog export#443
fixed sampler bank file dialog export#443kain88-de merged 5 commits intomixxxdj:masterfrom midzer:sample_bank_file_dialog
Conversation
|
Which version of Qt are you using? Since they say in the bug-report that it is fixed for qt 5.x it would be nice that you add a comment. Then we can remove it after we switched to qt 5. |
|
just added the comment as suggested by @kain88-de |
There was a problem hiding this comment.
It is enough to check for isEmpty with a string.
|
@kain88-de I removed unnecessary check and hope intendation is fixed now. |
There was a problem hiding this comment.
extrem nitpicking mode
line 45 and 46 contain tabs and the closing } is not intened correctly. Could you change that as well.
I'm not sure which editor you use. But assuming vim and you have defined tabs as 4 space characters you can use 'retab' to remove the tabs. To fix the indentation in an automated way use mark all lines of the if statement and hit =.
|
@kain88-de next try. i disabled tab intendation in Eclipse now. |
fixed sampler bank file dialog export
|
Yes it looks good now. Thanks |
2 participants
https://bugs.launchpad.net/mixxx/+bug/1403223
Although i did not find the dialog in question, i realized it is the same issue with QFileDialog under Linux as #430
I am unsure whether bug occurs under same environment in void SamplerBank::slotLoadSamplerBank() as well. Might need further attention.