Skip to content

fix playlist export bug#430

Merged
daschuer merged 1 commit intomixxxdj:masterfrom
midzer:master
Dec 16, 2014
Merged

fix playlist export bug#430
daschuer merged 1 commit intomixxxdj:masterfrom
midzer:master

Conversation

@midzer
Copy link
Copy Markdown
Contributor

@midzer midzer commented Dec 16, 2014

This PR should fix https://bugs.launchpad.net/mixxx/+bug/1197302
I am happy about any feedback.

Just getting used to Qt :)

@daschuer
Copy link
Copy Markdown
Member

Cool, that works like a charm on Ubuntu. Thank you.
@rryan: Should a Windows and a Mac user verify it or can we just merge?

@esbrandt
Copy link
Copy Markdown
Contributor

Confirmed as working on OSX 10.9.5

@daschuer
Copy link
Copy Markdown
Member

Thank you @esbrandt for testing. I can test it on windows once we have a binary from the buildserver after merge.

@midzer: Thank you for the fix. Just one Git hint: you should use feature branches for your PRs next time, this helps to find your branch for test.
git checkout -b super_feature master
Would you mind to have a look at https://bugs.launchpad.net/mixxx/+bug/1403223 as well?
It can be tested with load and save button in Deere skin.

daschuer added a commit that referenced this pull request Dec 16, 2014
fix playlist export bug
@daschuer daschuer merged commit 43a8f4e into mixxxdj:master Dec 16, 2014
@daschuer
Copy link
Copy Markdown
Member

Just tested: It works on Windows XP as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants