remove compatibility.h#4309
Conversation
|
I don't think so. We still need to support Qt 5.12. |
|
Oh I did not realize QWidget::screen was added in Qt 5.14. I can add one conditional hack for that, but I think we can still get rid of compatibility.h. |
|
Please don't remove the QUuid utility functions and tests, as these will still be needed in the future, e.g. for #2282. |
|
I suggest to first merge #4308 and then continue with the remaining tasks. |
|
I don't think we need to have unit tests for Qt. That's Qt's job. |
Qt doesn't provide a function that maps a null UUID to a null string. I have already populated some of my tags with those bogus UUIDs, don't underestimate even those simple functions. |
|
I have removed the obsolete utility function and tests from #4308. |
This was added for Qt < 5.6 but the conditional compilation supporting Qt < 5.6 was already removed. The function no longer serves a purpose.
Be-ing
force-pushed
the
devicepixelratio_qt56
branch
2 times, most recently
from
34d5ae6 to
dce1aad
Compare
|
Rebased and added one special case hack for Qt < 5.14. |
Be-ing
force-pushed
the
devicepixelratio_qt56
branch
3 times, most recently
from
aebc83d to
d82c367
Compare
Be-ing
force-pushed
the
devicepixelratio_qt56
branch
from
d82c367 to
ddefebd
Compare
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
devicePixelRatio() -> devicePixelRatioF()
This was added for Qt < 5.6 but the conditional compilation supporting Qt < 5.6 was already removed. The function no longer serves a purpose. Also remove compatibility.h
Be-ing
force-pushed
the
devicepixelratio_qt56
branch
from
ddefebd to
2f08b4f
Compare
|
Merge? |
|
LGTM |
|
Thank you for the speedy review. |
2 participants
None of it is needed anymore.