Fixed regression in coverart tooltip - The assert occured always#11153
Merged
daschuer merged 1 commit intoDec 24, 2022
Conversation
daschuer
approved these changes
Dec 24, 2022
Member
daschuer
left a comment
There was a problem hiding this comment.
Thank you. Looks and works good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression for QT>=5.14 introduced in #4309
If you move the mouse over a cover art in the library, the tool tip should appear, but due to this regression it always asserted. The function
parent()returns alwaysnullptr.Stacktrace: