Help menu: use north-east arrow as hyperlink suffix by ronso0 · Pull Request #3708 · mixxxdj/mixxx

ronso0 · 2021-03-15T00:07:33Z

Restore the north-east arrow for external links.

*ubuntu with xfce

Windows10

I also considered 🌐

but it may look really sh*#ty on various OS, also it's colored and distracting.

I think the arrow is fine, and much better than current =>
Looks fine on

*ubuntu
Windows
~~macOS~~ excluded

JoergAtGithub · 2021-03-15T00:16:59Z

A chain symbol is common for links, like here in GitHub

ronso0 · 2021-03-15T00:31:13Z

Sure, if you refer to https://unicode-table.com/en/1F517/

But it's a large icon. Here in the comment box it looks like this

and it's rendered like this
"Community Support 🔗"
On my system it looks like this

That's why I want to include a standard char from the Dingbats set which is included in the font we will use for the main menu #3704

ronso0 · 2021-03-15T00:42:39Z

with #3704

foss- · 2021-03-15T09:50:57Z

macOS 11.2.3
2.3.0-beta (build HEAD r8079)
If possible, remove arrow for macOS only as it is not used in menus.

ronso0 · 2021-03-15T12:51:37Z

but the => was shown in macOS previously, wasn't it?

Holzhaus · 2021-03-15T13:03:47Z

Maybe we could use this icon? https://www.fileformat.info/info/unicode/char/1f310/index.htm

ronso0 · 2021-03-15T15:12:52Z

(getting a server error)
my point here is just to get rid of those ugly characters which were introduced back then because windows couldn't display a hyperlink character.
I do not really want to invest work to append an SVG and test if that is displayed properly on all os.
the char added here is working on all os, and I can hide it on macOS.

foss- · 2021-03-15T15:50:11Z

but the => was shown in macOS previously, wasn't it?

Yes, but that was just as false for macOS.

ronso0 · 2021-03-15T17:09:07Z

@Holzhaus 0x1F310 is the globe I mentioned in the first post. It's in https://unicode-table.com/de/blocks/miscellaneous-symbols-and-pictographs/ and not guaranteed to work in most standard fonts, for example it's not in Open Sans.

btw that's the hyperlink char ; )

get rid of those ugly characters which were introduced back then because windows couldn't display a hyperlink character.

Holzhaus · 2021-03-15T23:15:55Z

This works for me. But for me it's non-obvious that the northeast arrow denotes a website.

Have you considered setting an SVG icon for the actions instead? E.g. a globe? it would be displayed on the left, but I think it would be more clear. Then you also have full control over the color.

ronso0 · 2021-03-18T02:01:58Z

This works for me. But for me it's non-obvious that the northeast arrow denotes a website.

square + north-east arrow is the default for external links for on wikipedia fr example, that's why I picked it.

Have you considered setting an SVG icon for the actions instead? E.g. a globe? it would be displayed on the left, but I think it would be more clear. Then you also have full control over the color.

nope, because IMO a globe at this size doesn't make much sense. If I look at other menu icons, in file managers for example, I find the combination of icon size and level of detail not very helpful tbh. On screens with regular dpi (96?) I find those icons rather blurry and the only thing that helps me to navigate is mostly the color, maybe the rough shape, but the details are useless IMO.
Firefox bookmark menu:

ronso0 · 2021-03-18T02:04:00Z

Are there any obejctions to merge this, even if it's just a quick fix to get rid of => ?

daschuer · 2021-03-18T07:08:37Z

As far as I remember it was originally the ↗
We have removed it because of windows XP.
Nice that we are back now.

daschuer · 2021-03-18T07:10:25Z


-    QString externalLinkSuffix = " =>";
+    QString externalLinkSuffix;
+#ifndef __APPLE__ // external links don't have icons on macOS


accoring to ....

Please extend the comment.

acording to screenshots from @foss- and web search for 'macos help menu'

daschuer · 2021-03-18T07:13:46Z

Did we have confirmation that this works on Windows?

ronso0 · 2021-03-18T12:37:57Z

not yet. will test it tonight myself on Win10

daschuer · 2021-03-18T13:22:00Z

I have found the apple user interface guidelines.
They defin a small set of symbols. Our north west icon is not one of them.

They also want "Title Style Capitalization"
This matter for "Translate this Application"
When at all, a 2.4 topic to not break translations.

foss- · 2021-03-18T13:33:42Z

Not sure we should overcomplicate this. @daschuer why are we discussing icon design for macOS? There will not be any icon shown on macOS for Menubar > Help items. So there really is nothing to discuss in that regard.

Mixxx uses Title Style Capitalization so nothing to change in that regard or am I missing something? Besides not the scope of this specific PR.

For reference here's the Apple Human Interface Guidelines.

daschuer · 2021-03-18T13:40:51Z

I am fine with the look here. It is just a matter of documentation the special case code.

The this in "Translate this Application" needs to be lower case to be fully complaint.

esbrandt · 2021-03-18T17:18:48Z

As far as I remember it was originally the ↗
We have removed it because of windows XP.
Nice that we are back now.

The cycle is completed.
86689e3
👍

ronso0 · 2021-03-19T01:51:14Z

To wrap up the macOS topic:
@daschuer I assume you refer to 'Using Symbols in Menus' in https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/
Indeed the arrow is not mentioned, also they encourage to "Avoid using custom symbols in menus"
Otoh we can't compare the Mixxx Help menu with other macOS apps as appearantly the Help item there is usually meant to search the app's help book.
So special case here, let's just leave not show it on macOS to not confuse anyone ; \

Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>

ronso0 · 2021-03-19T02:10:27Z

Ready for merge..

ronso0 · 2021-03-19T02:24:12Z

okay, so we try to have a local manual.
let's also have a local cheat sheet for keyboard shortcuts then, right?

the PNG from the manual will do.
actually a PDF created from /res/images/templates/ic_template_keyboard_mapping_sheet.svg could be really small but unfortunately all key labels are already converted to paths :\

esbrandt · 2021-03-19T07:34:45Z

actually a PDF created from /res/images/templates/ic_template_keyboard_mapping_sheet.svg could be really small but unfortunately all key labels are already converted to paths :\

A pdf generated from the template is about 300 kb in size. Too big?

I find it rather problematic that the keyboard's labeling is En-US, which does not apply to a lot of our users. Perhaps we should simply omit the labels (except for the function keys).

ronso0 · 2021-03-19T12:54:33Z

hmkay, when I exported it was 1.6mb.
yes, omitting the labels would work for me

Holzhaus · 2021-03-19T13:00:29Z

Perhaps we should simply omit the labels (except for the function keys).

Maybe I'm nitpicking but there are more differences between ANSI keyboards and ISO keyboards than just the labels (notably size of the return key). But I'm fine with whatever you decide here :D

ronso0 · 2021-03-20T17:28:29Z

Alright, let's add the keyboard cheat sheet in another PR. I'll have to learn about including it in the packing process first.
@esbrandt Can you describe your PDF export process and settings? I tried with the default settings in Inkscape which resulted in the aforementioned 1.6mb

ronso0 · 2021-03-20T17:28:36Z

So this here is ready to be merged, right?
This is how it looks like on Windows10

daschuer · 2021-03-20T18:40:46Z

Yes thank you.

esbrandt · 2021-03-20T19:26:09Z

@esbrandt Can you describe your PDF export process and settings? I tried with the default settings in Inkscape which resulted in the aforementioned 1.6mb

Exporting with Inkscape results in 300 kb pdf
ic_template_keyboard_mapping_sheet.pdf

Setting used:

github-actions Bot added the ui label Mar 15, 2021

ronso0 added this to the 2.3.0 milestone Mar 15, 2021

ronso0 force-pushed the help-hyperlink branch from 3249a28 to a0257d5 Compare March 15, 2021 17:14

daschuer reviewed Mar 18, 2021

View reviewed changes

Comment thread src/widget/wmainmenubar.cpp Outdated

ronso0 marked this pull request as draft March 19, 2021 01:33

ronso0 closed this Mar 19, 2021

ronso0 reopened this Mar 19, 2021

ronso0 and others added 2 commits March 19, 2021 03:08

Help menu: use north-east arrow as hyperlink icon

fafbc77

Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>

Help menu: don't show hyperlink icon on macOS

1ba21ef

Help menu: use hyperlink icon only when directing to online manual

7b02ab0

ronso0 force-pushed the help-hyperlink branch from a044937 to 7b02ab0 Compare March 19, 2021 02:09

ronso0 marked this pull request as ready for review March 19, 2021 02:09

daschuer merged commit 780a209 into mixxxdj:2.3 Mar 20, 2021

ronso0 deleted the help-hyperlink branch March 20, 2021 18:44

Uh oh!

Conversation

ronso0 commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoergAtGithub commented Mar 15, 2021

Uh oh!

ronso0 commented Mar 15, 2021

Uh oh!

ronso0 commented Mar 15, 2021

Uh oh!

foss- commented Mar 15, 2021

Uh oh!

ronso0 commented Mar 15, 2021

Uh oh!

Holzhaus commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

foss- commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Mar 15, 2021

Uh oh!

Holzhaus commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Mar 18, 2021

Uh oh!

ronso0 commented Mar 18, 2021

Uh oh!

daschuer commented Mar 18, 2021

Uh oh!

daschuer Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daschuer commented Mar 18, 2021

Uh oh!

ronso0 commented Mar 18, 2021

Uh oh!

daschuer commented Mar 18, 2021

Uh oh!

foss- commented Mar 18, 2021

Uh oh!

daschuer commented Mar 18, 2021

Uh oh!

esbrandt commented Mar 18, 2021

Uh oh!

ronso0 commented Mar 19, 2021

Uh oh!

ronso0 commented Mar 19, 2021

Uh oh!

ronso0 commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esbrandt commented Mar 19, 2021

Uh oh!

ronso0 commented Mar 19, 2021

Uh oh!

Holzhaus commented Mar 19, 2021

Uh oh!

ronso0 commented Mar 20, 2021

Uh oh!

ronso0 commented Mar 20, 2021

Uh oh!

daschuer commented Mar 20, 2021

Uh oh!

esbrandt commented Mar 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

ronso0 commented Mar 15, 2021 •

edited

Loading

Holzhaus commented Mar 15, 2021 •

edited

Loading

ronso0 commented Mar 15, 2021 •

edited

Loading

foss- commented Mar 15, 2021 •

edited

Loading

Holzhaus commented Mar 15, 2021 •

edited

Loading

daschuer Mar 18, 2021 •

edited

Loading

ronso0 commented Mar 19, 2021 •

edited

Loading