DlgController: add link to xml file#3387
Merged
Holzhaus merged 2 commits intomixxxdj:2.3from Nov 29, 2020
Merged
Conversation
Holzhaus
reviewed
Nov 29, 2020
| </property> | ||
| <property name="text"> | ||
| <string>Script Files:</string> | ||
| <string>Preset Files:</string> |
Member
There was a problem hiding this comment.
IIRC we wanted to get rid of the "Preset" term and use "Mapping" instead.
Member
Author
There was a problem hiding this comment.
okay, will do that for all user-visible strings.
Also I found some places were my changes can be improved.
ronso0
force-pushed
the
midi-xml-link
branch
from
d999fff to
af26ca6
Compare
Member
Author
|
Done, ready for review! |
Holzhaus
requested changes
Nov 29, 2020
Member
Holzhaus
left a comment
Holzhaus
left a comment
There was a problem hiding this comment.
Thanks! The "(built-in)" suffix for XML files is missing. Can you add it?
ronso0
force-pushed
the
midi-xml-link
branch
from
af26ca6 to
037ea12
Compare
Member
Author
Done. |
Member
Can you move it out of the link?
|
ronso0
force-pushed
the
midi-xml-link
branch
from
037ea12 to
2090a15
Compare
ronso0
force-pushed
the
midi-xml-link
branch
from
2090a15 to
d482285
Compare
Member
Author
oh, of course. |
Member
|
Waiting for CI. |
Holzhaus
added a commit
to Holzhaus/manual
that referenced
this pull request
Dec 2, 2020
This fixes the inconsistent terminology and is also necessary now that mixxxdj/mixxx#3387 has been merged.
3 tasks
Be-ing
pushed a commit
that referenced
this pull request
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the script files, also show a clickable link to the base xml file