Traktor S3 by ywwg · Pull Request #308 · mixxxdj/manual

ywwg · 2020-11-18T01:31:21Z

Add manual page for the Traktor Kontrol S3

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

ywwg · 2020-11-18T02:23:35Z

notes addressed

ywwg · 2020-11-18T03:13:00Z

sphinx failures appear not to be my problem (errors in other files)

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

ywwg · 2020-11-18T14:16:26Z

notes addressed

…_s3.rst Co-authored-by: Be <be.0@gmx.com>

ywwg · 2020-11-21T15:46:17Z

notes addressed again

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Be-ing · 2020-12-08T04:38:54Z

I don't see anything about how the pad grid works.

ywwg · 2021-02-15T22:53:03Z

I don't see anything about how the pad grid works.

added

Be-ing · 2021-02-15T22:53:46Z

Did you forget to push?

ywwg · 2021-02-15T23:00:28Z

I wish github would let me queue up my replies so I could push and reply at the same time lol. I was still working

Be-ing · 2021-02-16T00:01:14Z

 Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:180: WARNING: Unexpected indentation.

Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:182: WARNING: Block quote ends without a blank line; unexpected unindent.
Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:185: WARNING: Enumerated list ends without a blank line; unexpected unindent.

Holzhaus · 2021-02-16T00:31:24Z

Btw, both the manual and the website repo have a pre-commit config that let's you check these kinds of issues when committing.

…_s3.rst call it a "limited effects" controller Co-authored-by: Be <be.0@gmx.com>

…_s3.rst Traktor S3: commit suggestion Co-authored-by: Be <be.0@gmx.com>

Be-ing · 2021-02-16T03:34:19Z

 Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:218: WARNING: Title underline too short.

Effect Chain Edit Mode
~~~~~~~~~~~~~~~~~
Warning: /home/runner/work/manual/manual/source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst:218: WARNING: Title underline too short.

Effect Chain Edit Mode
~~~~~~~~~~~~~~~~~

Traktor S3: manual

b9abc7e

Holzhaus requested changes Nov 18, 2020

View reviewed changes

ywwg and others added 6 commits November 17, 2020 21:04

Update source/hardware/controllers/native_instruments_traktor_kontrol…

08935e1

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update source/hardware/controllers/native_instruments_traktor_kontrol…

01c48c1

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Traktor S3: Address Notes

eab118b

Traktor S3: remove image

e99a83e

Traktor S3: remove image

6b731a2

Merge remote-tracking branch 'ywwg/traktor-s3' into traktor-s3

f31afd8

Traktor S3: fix enumeration

f638690

JoergAtGithub reviewed Nov 18, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Holzhaus requested changes Nov 18, 2020

View reviewed changes

ywwg and others added 5 commits November 18, 2020 09:12

Update source/hardware/controllers/native_instruments_traktor_kontrol…

a170c97

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Update source/hardware/controllers/native_instruments_traktor_kontrol…

743e61a

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Traktor S3: Address notes

38fe823

Merge remote-tracking branch 'ywwg/traktor-s3' into traktor-s3

9563908

Traktor S3: clarify a piece about shift buttons

ad6d345

Traktor S3: fix file label

710e7ff

ywwg requested a review from Holzhaus November 19, 2020 03:11

Be-ing reviewed Nov 20, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Nov 20, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

ywwg and others added 3 commits November 21, 2020 10:43

Update source/hardware/controllers/native_instruments_traktor_kontrol…

812aa49

…_s3.rst Co-authored-by: Be <be.0@gmx.com>

Traktor S3: remove reference to midi

2d5f95a

Merge branch 'traktor-s3' of github.com:ywwg/manual into traktor-s3

b56e44c

ywwg requested a review from Be-ing November 21, 2020 15:46

Holzhaus requested changes Nov 21, 2020

View reviewed changes

Update source/hardware/controllers/native_instruments_traktor_kontrol…

4be4a64

…_s3.rst Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>

Be-ing reviewed Dec 8, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Dec 8, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Dec 8, 2020

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst

Holzhaus mentioned this pull request Dec 16, 2020

Traktor s3 2.3 mixxxdj/mixxx#3031

Merged

ywwg added 5 commits January 30, 2021 19:31

Traktor S3: Add information about pads and effects controls

34a78b6

Traktor S3: Document JOG and SHIFT+Wheel behavior

d7f08ce

Traktor S3: Correction

bbad7c6

Traktor S3: Add shift+right encoder

9282e51

Traktor S3: Update manual for jog button change

8a766ac

Traktor S3: various updates for notes -- clarify inputs

aa41ab7

Be-ing reviewed Feb 15, 2021

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Feb 16, 2021

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Feb 16, 2021

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Feb 16, 2021

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

Be-ing reviewed Feb 16, 2021

View reviewed changes

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s3.rst Outdated

ywwg and others added 5 commits February 15, 2021 21:57

Update source/hardware/controllers/native_instruments_traktor_kontrol…

d75a6da

…_s3.rst call it a "limited effects" controller Co-authored-by: Be <be.0@gmx.com>

Update source/hardware/controllers/native_instruments_traktor_kontrol…

4ea5264

…_s3.rst Traktor S3: commit suggestion Co-authored-by: Be <be.0@gmx.com>

Update source/hardware/controllers/native_instruments_traktor_kontrol…

06873b7

…_s3.rst Traktor S3: commit suggestion Co-authored-by: Be <be.0@gmx.com>

Traktor S3: Clarify some effect lanugage

2fed307

Merge branch 'traktor-s3' of github.com:ywwg/manual into traktor-s3

93b3984

Traktor S3: underline nit

fcf8483

ywwg requested a review from Be-ing February 16, 2021 16:44

Be-ing merged commit 80dd9fd into mixxxdj:2.3 Feb 16, 2021

Conversation

ywwg commented Nov 18, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ywwg commented Nov 18, 2020

Uh oh!

ywwg commented Nov 18, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ywwg commented Nov 18, 2020

Uh oh!

Uh oh!

Uh oh!

ywwg commented Nov 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Be-ing commented Dec 8, 2020

Uh oh!

Uh oh!

ywwg commented Feb 15, 2021

Uh oh!

Be-ing commented Feb 15, 2021

Uh oh!

ywwg commented Feb 15, 2021

Uh oh!

Uh oh!

Be-ing commented Feb 16, 2021

Uh oh!

Holzhaus commented Feb 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Be-ing commented Feb 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants