Skip to content

check for rlimits on Linux#31

Merged
daschuer merged 2 commits into
mixxxdj:masterfrom
daschuer:limits
Jul 3, 2013
Merged

check for rlimits on Linux#31
daschuer merged 2 commits into
mixxxdj:masterfrom
daschuer:limits

Conversation

@daschuer
Copy link
Copy Markdown
Member

@daschuer daschuer commented Jul 2, 2013

Gives a hint in sound preferences if the Limits are not set.

Comment thread src/util/rlimit.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the absolute path:
#include "util/rlimit.h"

@rryan
Copy link
Copy Markdown
Member

rryan commented Jul 2, 2013

Other than the minor comments, LGTM

@esbrandt
Copy link
Copy Markdown
Contributor

esbrandt commented Jul 3, 2013

Imo we can leave out translator comments here, because dealing with small HTML blobs like links or %1 variables are explained in the glossary as well as the translator pages, see http://mixxx.org/wiki/doku.php/internationalization . OTOH I would suggest to delete the <ul> tags ,also for the other bullet points in the latency tips. If we`d move them to separate rows in a horizontal layout, each line is presented as separate string in the translation interface.

@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Jul 3, 2013

I am in favor not to change the lines above, because they are already translated. If we try to make them more easy to translate by changing them we will in fact force the translators to translate them again.

daschuer added a commit that referenced this pull request Jul 3, 2013
check for rlimits on Linux
@daschuer daschuer merged commit 9f1d25e into mixxxdj:master Jul 3, 2013
@esbrandt
Copy link
Copy Markdown
Contributor

If the check is performed on Linux only, isn't it redundant to display the hint in sound preferences on Mac ( and probably Windows)?
about mixxx

@daschuer
Copy link
Copy Markdown
Member Author

This should be only displayed in the Linux version. I will prepare a fix.

@daschuer
Copy link
Copy Markdown
Member Author

Fixed in r3520 3069596

@daschuer daschuer mentioned this pull request Dec 28, 2014
daschuer added a commit that referenced this pull request Apr 5, 2018
2.1 RC1 CHANGELOG updates
@daschuer daschuer mentioned this pull request Jun 11, 2018
11 tasks
Swiftb0y referenced this pull request in Swiftb0y/mixxx Nov 3, 2019
Holzhaus pushed a commit to Holzhaus/mixxx that referenced this pull request Aug 23, 2020
m0dB pushed a commit to m0dB/mixxx that referenced this pull request Jan 21, 2024
koushikcs562 pushed a commit to koushikcs562/mixxx that referenced this pull request Dec 23, 2025
Signed-off-by: Bili Dong <qobilidop@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants