Add the fallback to the internal libShout to cmake as well

[daschuer]

This fixes lp1833225 also for cmake builds
https://bugs.launchpad.net/mixxx/+bug/1875013

I have verified that it still works and that we use the same build flags as the Ubuntu System lib.

[Holzhaus]

Look good, but idn't test yet.

[daschuer]

OK, extra message is in place.

[daschuer]

Ups, It has always used the system lib for linking.
Now I have uninstalled it and it still builds.

And broadcasting is still working :-)

[Holzhaus]

Seems to work, but the printed messages could be improved because it doesn't even mention libshout.

[daschuer]

Done.

[Holzhaus]

Thank you!

[jospezial]

https://bugs.launchpad.net/mixxx/+bug/1833225 should be fixed now with latest libshout-2.4.4 and libshout-2.4.5 releases.

https://gitlab.xiph.org/xiph/icecast-libshout/-/blob/master/NEWS
libshout 2.4.5 (20201219)

• Improved shout.h for reading, and understanding.
• Marked dumpfile support as obsolete (as SHOUT_PROTOCOL_XAUDIOCAST already is).
• Added Support for setting the content language.
• Avoid the use of obsolete functions (Tango :: scaling fixes for sliders #2317).
• Several small fixes for non-blocking mode (lp1846971: Fix database inconsistencies caused by LibraryScanner #2321, Recover from FLAC decoding errors #2315).
• Corrected detection of libogg (mostly for windows targets).
• Now accept TLS mode "auto" when build without TLS support.
• Added new tool shout(1).

libshout 2.4.4 (20201001)

• Fixed handling of blocking/non-blocking mode
• Fixed ICY port increment
• Fixed reusing of handles
• Fixed error handling of Ogg sync layer
• Fixed Passing of errors between connection and instance layer
  Without this fix died connections were not correctly detected.
• Fixed and improved build scripts

libshout-2.4.5 is not tagged yet as release but downloadable:
https://ftp.osuosl.org/pub/xiph/releases/libshout/libshout-2.4.5.tar.gz

I have tried now with libshout-2.4.5 installed in my system
but configure still says it wants to use the bundled internal libshout.

-- Found Shout: /usr/lib64/libshout.so
-- Installed libshout version is suffering from bug lp1833225
-- Using internal libshout
-- Found OpenSSL: /usr/lib64/libcrypto.so (found version "1.1.1i")

/usr/lib64/pkgconfig/shout.pc has
Version: 2.4.5

lrwxrwxrwx 1 root root 17 30. Dez 12:54 /usr/lib64/libshout.so -> libshout.so.3.2.0
lrwxrwxrwx 1 root root 17 30. Dez 12:54 /usr/lib64/libshout.so.3 -> libshout.so.3.2.0
-rwxr-xr-x 1 root root 126880 30. Dez 12:54 /usr/lib64/libshout.so.3.2.0

See also Gentoo bug:
https://bugs.gentoo.org/739498#c26

[jospezial]

If I remove "QUIET" in FindShout.cmake:
-- Checking for module 'shout'
-- Found shout, version 2.4.5

[Be-ing]

@jospezial if you find a fix, please open a pull request.

[jospezial]

There must be something wrong with

if(Shout_FOUND AND Shout_VERSION VERSION_LESS 2.4.4)
and line
if(NOT Shout_FOUND OR Shout_VERSION VERSION_LESS 2.4.4)

but there end my skills about programming.

[fordfrog]

@jospezial i personally would add lines just before these lines to get the output of Shout_FOUND and Shout_VERSION to see why the conditions are true.

[daschuer]

Oh I see FindShout.cmake does not set Shout_VERSION. I will provide a fix.

[daschuer]

Fixed in: #3505