Skip to content

Tango :: scaling fixes for sliders#2317

Closed
ronso0 wants to merge 1 commit into
mixxxdj:masterfrom
ronso0:skins-scaling-fixes
Closed

Tango :: scaling fixes for sliders#2317
ronso0 wants to merge 1 commit into
mixxxdj:masterfrom
ronso0:skins-scaling-fixes

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Oct 7, 2019

before sliders looked blurry because the original graphics were zoomed but not scaled.
scalemode="STRETCH_ASPECT" fixed it

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 7, 2019

I tried working on this a while ago but ran into the same issue as this PR. The volume faders disappear:
image
When I tried working on this before, I attempted to debug the WSliderComposed C++ code but couldn't figure out what was going wrong.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Oct 7, 2019

Whoopsy... I noticed this with the crossfader, master balance and cue balance as well.
Fixing the <Size> solved the issue.
Will add it to the Vol faders now

@Be-ing Be-ing changed the base branch from master to 2.2 October 7, 2019 17:36
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 7, 2019

Nice, it works now. Can you rebase this on the 2.2 branch?

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Oct 7, 2019

rebase as well restart with 2.2 plus cherry-pick (sqhased commits) result in conflicts..tedious to resolve them
Please set this back to Based this on master again and I'll open another PR for 2.2

@ronso0 ronso0 force-pushed the skins-scaling-fixes branch from 1e0ae98 to 472d518 Compare October 7, 2019 18:35
@ronso0 ronso0 changed the base branch from 2.2 to master October 7, 2019 18:36
@Be-ing Be-ing closed this Oct 7, 2019
@ronso0 ronso0 deleted the skins-scaling-fixes branch October 25, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants