Skip to content

Rename the "Reload from Musicbrainz" option in the context menu and opti...#27

Merged
rryan merged 1 commit into
mixxxdj:masterfrom
esbrandt:lp1184157
Jun 28, 2013
Merged

Rename the "Reload from Musicbrainz" option in the context menu and opti...#27
rryan merged 1 commit into
mixxxdj:masterfrom
esbrandt:lp1184157

Conversation

@esbrandt
Copy link
Copy Markdown
Contributor

...mize MB dialog, https://bugs.launchpad.net/mixxx/+bug/1184157

  • Add separator in the context menu to group metadata related menu points
  • Rename available options to "Reload Metadata from File" and "Get Metadata from MusicBrainz"
    Since all options in this menu are somehow related to a track, it was reasonable to drop the extra "track" from
    both menu points.
  • In the MusicBrainz fetcher dialog:
    • Add descriptive Title to the dialog window
    • Add some translator comments
    • Change Song -> Track
    • Change button order to be like in the Tracks Properties dialog
    • Use Ampersands (&) for button text to quickly access that particular GUI element.
    • Fix tab order.
    • Removes styling for some text in error messages. We already have different styles in the preferences dialogs (which is bad and needs clean up), go with the system default instead.
  • In the Tracks Properties dialog, metadata buttons are now in the same order like in the context menu. Also fix tab order.

@rryan
Copy link
Copy Markdown
Member

rryan commented Jun 28, 2013

LGTM -- thanks!

rryan added a commit that referenced this pull request Jun 28, 2013
Rename the "Reload from Musicbrainz" option in the context menu and opti...
@rryan rryan merged commit f5ce1e4 into mixxxdj:master Jun 28, 2013
@daschuer daschuer mentioned this pull request Dec 28, 2014
@esbrandt esbrandt deleted the lp1184157 branch January 27, 2018 14:29
ronso0 referenced this pull request in ronso0/mixxx Jan 29, 2018
better contrast in color shemes
@daschuer daschuer mentioned this pull request Jun 11, 2018
11 tasks
ronso0 referenced this pull request in ronso0/mixxx Oct 15, 2019
Swiftb0y referenced this pull request in Swiftb0y/mixxx Aug 3, 2022
#27)

refactor(prefs): improve keylockengine-related typesafety
m0dB pushed a commit to m0dB/mixxx that referenced this pull request Jan 21, 2024
change front page title to reflect data from search terms
koushikcs562 pushed a commit to koushikcs562/mixxx that referenced this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants