Bug 1000784

[troyane]

That is my first pull request.
My idea was to fix bug https://bugs.launchpad.net/mixxx/+bug/1000784.

[ywwg]

spaces around the ==

[daschuer]

one == slipped through

[rryan]

These all look like reasonable error messages to add to the SoundSources but they would only be triggered when we are loading the file (e.g. loading to a deck or analyzing). TagLib is what we use to analyze the files during library scanning and it doesn't look like this changes our taglib code at all (located in src/soundsource.cpp).

[rryan]

Also @troyane, you should merge with master to get the latest changes. I think you have some conflicts with changes I made in soundsourcecoreaudio.cpp in master.

[rryan]

Sorry -- misread. Adding logging for when parseHeader() would return ERR is good but maybe that belongs in the SoundSource::process* functions? That way you could report more details about the erorr (TagLib couldn't parse AudioProperties, etc.) And you don't have to duplicate the error checks in every SoundSource's parseHeader.

[daschuer]

here is a type mismatch: const int ERR = -1; bool result

[daschuer]

Please fix also the implicit cast at:
https://github.com/troyane/mixxx/blob/master/src/soundsource.cpp#L271

[daschuer]

For me this is in a merge-able state. But RJ has made a valid point:

So it would be nice if you could move all warnings from the bottom of each parseHeader() to
https://github.com/mixxxdj/mixxx/blob/HEAD/src/soundsourceproxy.cpp#L365.
If this is not the only place where parseHeader(), then on the other places as well.

By the way: I think setting p->setHeaderParsed(false); looks like a bug, because the Header was actual passed but without success. So it makes no scene to try it again later.

[troyane]

@daschuer, thanks. I'll do it.

[troyane]

Please, check it, troyane@9f710b4.

[daschuer]

@troyane: Thank you!