open cover art view on left click release

[ronso0]

..instead of on button press.

This keeps the view clean when dragging a coverart widget to another deck, playlist etc.
https://bugs.launchpad.net/mixxx/+bug/1844730

[daschuer]

Ah, got it. The single click cover interferes with starting a drag event.
Can we use the mouseMove even instead of the timer?
Like omit showing the cover if a drag action had been started.

[ronso0]

I'm not sure.
I used a timer for the cover window drag, too, because the goal is to make it work on all hardware because and I have made some experience with touch screens where the release would have slight offset due to the vage touch area with fingers.
Though, I don't know if that's still relevant today, it's just my experience.

you think of something like m_mouseMoved is set true when a move is registered, and false on release?

[daschuer]

That was my first idea.
But if you have a better experience with the timer solution we can stick with it.

[ronso0]

In my experience the timer solution already works well for the cover window drag moves from #2072

But it would be nice to have a const global timeout for those mouse events (not button interaction like power_window etc.).
What's the best place to set that const (i.e. kGuiLongpressTimeOut)? In mixxx.cpp like const int MixxxMainWindow::kMicrophoneCount?

[daschuer]

LGTM. Thank you.