Skip to content

make cover art window draggable#2072

Merged
daschuer merged 1 commit intomixxxdj:masterfrom
ronso0:coverart-drag
Apr 3, 2019
Merged

make cover art window draggable#2072
daschuer merged 1 commit intomixxxdj:masterfrom
ronso0:coverart-drag

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Apr 2, 2019

keep left mouse button pressed and move cursor to drag the Cover window.

it has bothered me having to aim for the window title bar to move the Cover window.
now it's super easy, still closes after short click.

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Apr 3, 2019

LGTM and works nice.
I find myself double clicking the cover art which let it show and disappear.
An other serious issue is that I can't close the window if the cover art is empty.
In this case I see instead of the white background a copy of the Mixxx skin.
This is not a regression from this PR. I will file a bug.

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Apr 3, 2019

We have it already:
https://bugs.launchpad.net/mixxx/+bug/1807450

@daschuer daschuer merged commit fad209a into mixxxdj:master Apr 3, 2019
@ronso0 ronso0 deleted the coverart-drag branch April 9, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants