Skip to content

Only highlight crates/playlists when a single track is selected #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daschuer merged 1 commit into from
Sep 28, 2019
Merged

Only highlight crates/playlists when a single track is selected #2242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/widget/wtracktableview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,20 +209,23 @@ void WTrackTableView::slotGuiTick50ms(double /*unused*/) {
mixxx::Duration timeDelta = mixxx::Time::elapsed() - m_lastUserAction;
if (m_loadCachedOnly && timeDelta > mixxx::Duration::fromMillis(100)) {

// Show the currently selected track in the large cover art view. Doing
// this in selectionChanged slows down scrolling performance so we wait
// until the user has stopped interacting first.
// Show the currently selected track in the large cover art view and
// hightlights crate and playlists. Doing this in selectionChanged
// slows down scrolling performance so we wait until the user has
// stopped interacting first.
if (m_selectionChangedSinceLastGuiTick) {
const QModelIndexList indices = selectionModel()->selectedRows();
if (indices.size() > 0 && indices.last().isValid()) {
if (indices.size() == 1 && indices.first().isValid()) {
// A single track has been selected
TrackModel* trackModel = getTrackModel();
if (trackModel) {
TrackPointer pTrack = trackModel->getTrack(indices.last());
TrackPointer pTrack = trackModel->getTrack(indices.first());
if (pTrack) {
emit(trackSelected(pTrack));
}
}
} else {
// None or multiple tracks have been selected
emit(trackSelected(TrackPointer()));
}
m_selectionChangedSinceLastGuiTick = false;
Expand Down