Only highlight crates/playlists when a single track is selected#2242
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Sep 28, 2019
uklotzde:2.2_track_selected
Merged
Only highlight crates/playlists when a single track is selected#2242daschuer merged 1 commit intomixxxdj:masterfrom uklotzde:2.2_track_selected
daschuer merged 1 commit intomixxxdj:masterfrom
uklotzde:2.2_track_selected
Conversation
uklotzde
changed the title
Contributor
Author
|
Created a bug report to promote this easy and effective fix: https://bugs.launchpad.net/mixxx/+bug/1844914 |
Member
|
LGTM, Thank you. |
Contributor
Author
|
Oh, I've selected the wrong branch. A manual cherry-pick for 2.2 should work. |
Contributor
Author
|
Done: 95dde5d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting multiple tracks creates a very inconsistent experience. Sometime crates and playlists get highlighted, sometimes not. It is not obvious why and how this happens when selecting more than 1 track.
The signal that a track is selected must only be sent if exactly 1 track is selected! Otherwise an empty track pointer is sent to indicate that no single selected track is available and all view changes are properly reset to the default state.
Detected while verifying this bug report: https://www.mixxx.org/forums/viewtopic.php?f=1&t=12368&p=42659