Skip to content

Make controller shutdown easier for components JS based mappings.#2052

Merged
Be-ing merged 1 commit intomixxxdj:masterfrom
Swiftb0y:components_js_shutdown
Sep 1, 2019
Merged

Make controller shutdown easier for components JS based mappings.#2052
Be-ing merged 1 commit intomixxxdj:masterfrom
Swiftb0y:components_js_shutdown

Conversation

@Swiftb0y
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y commented Mar 5, 2019

TODO:

  • Document on Wiki

@Swiftb0y Swiftb0y mentioned this pull request Mar 14, 2019
17 tasks
@uklotzde uklotzde added this to the 2.3.0 milestone Apr 24, 2019
@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Aug 1, 2019

I just added this sentence to the ComponentContainer documentation:

  • shutdown: Iterate over all Components and call their shutdown methods. The Button is the only component with a predefined shutdown method. All other components have to be implemented manually.

is this sufficient as documentation?

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Sep 1, 2019

LGTM thanks for this nice little addition.

@Be-ing Be-ing merged commit f3395e8 into mixxxdj:master Sep 1, 2019
@Swiftb0y Swiftb0y mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants