Numark NS6II Controller Mapping#2049
Closed
Swiftb0y wants to merge 11 commits intomixxxdj:masterfrom
Closed
Conversation
Member
|
What's the status of this PR? |
Member
Author
|
Stalled. I decided I will rewrite it after #1795 got merged (and we possibly adapted the components library to ES7 as well). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is mostly completed / ready for review.
However, I wasn't able to test it yet to the required extend.
Features:
Known Issues:
duration*playposition(instead of rate-adjustedtime_elapsed/time_remaining) (won't fix; I'll consider it while reworking the mapping with QJSEngine)printdebugging statements still present.Related/Dependent PRs: