Merged
Conversation
Be-ing
suggested changes
Dec 16, 2018
Contributor
Be-ing
left a comment
Be-ing
left a comment
There was a problem hiding this comment.
Thanks for following up on this. Can you rebase this on the 2.2 branch? Also, use git rebase -i to reorder the commits so the changes to Lodash are committed before the controller script makes use of them.
Swiftb0y
force-pushed
the
NumarkN4_hotfix1
branch
from
185babb to
3a272e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some Issues with my recently merged Numark N4 mapping (#1815) which this PR is supposed to fix.
I would appreciate if this could still get into 2.2 in time.