Skip to content

Numark N4 remake#1815

Merged
Be-ing merged 38 commits intomixxxdj:2.2from
Swiftb0y:N4v2
Nov 26, 2018
Merged

Numark N4 remake#1815
Be-ing merged 38 commits intomixxxdj:2.2from
Swiftb0y:N4v2

Conversation

@Swiftb0y
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y commented Sep 21, 2018 •
edited
Loading

I felt very limited by the old mapping so I created my fully fledged remake of the old mapping.
Features:

  • seamless integration of crossfader orientation and PFL-buttons (work differently on the N4 than in Mixxx)
  • all the necessary controls for looping
  • support for up to 16 hotcues
  • full control over the library navigation
  • basic fx unit control
  • switching Deck3&4 between PC- and line-in
  • used components.js for better read- and maintainability
  • all the usual/labeled controls on the N4 work
    I tried to PR the mapping earlier this year but it still had too many bugs and I didn't have time to fix them back then, so I closed the PR.

Swiftb0y added 22 commits March 22, 2018 21:27
half finished sketch for a better Numark N4 mappping
4d59f25
added xml mapping
b9ea00a
bpmSlider is now handled in script; inverting bug persists.
58a065b
commit for merging mixxx 2.1
038313c
Merge branch 'master' into N4v2
ab6dc3d
working commit, some bugfixing still required
ddae75e
add sysEx sync on startup and pflVuMeter prototype
12c53d7
working commit, finished; may need some testing.
3f7f90d
added basic shutoff; removed debug prints; added channelindicator lights
e73d9d1
removed outdated mappings
a34bd4a
fixed missing comma @222:98
d52f58c
added configurable option for cueBtn reverse roll on shift.
15568d7
function based input methods now component based; removed dead code;
1bd341b
removed keylockbtn quantize function since handled by SyncButton.shift
a15950b
fixed bpmslider direction to match with controller: Down speeds up.
f397adc
fixed missing } and ; Swapped Maximize Library and GoToItem; init output
1310b35
fixed script breaking typos
48386b7
fixed deckchange; added feature to scratch button
d678718
added midi-off bindings to hotcue buttons; fixed channel2 pitchbend+
a499bc7
changed default headgain to 0.5; fixed broken mute when using line-in
8e72956
added shift function to keylock key (sync_key); fixed raterange offset
8c4f32f
fixed missing cuebutton release binding
a72963e
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 8, 2018 •
edited
Loading

Thanks for taking care of this older controller. Is the wiki up to date with your latest changes?

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 20, 2018

Ping @Swiftb0y, can you confirm that the wiki is up to date with the mapping before I review it?

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Oct 20, 2018

Oh sorry. I forgot about this because of #1830 but I'll try to get around updating the wiki this evening.

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Oct 20, 2018

@Be-ing turns out there wasn't much to change. The Wiki is up-to-date now.

@rryan
Copy link
Copy Markdown
Member

rryan commented Nov 4, 2018

Status? It'd be nice to have this in 2.2!

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Nov 4, 2018

Its pretty much done but I recently discovered a "bug" where the hotcuepage doesn't reset when a new track gets loaded, So I want to update that before merging. I'll try to fix that today.

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Nov 5, 2018

I don't think I will be able to solve that hotcuepage issue in time as it would probably require a change within the C++ source (which I'm not comfortable with this shortly before release, especially because I can't test for unintended side effects within other mappings). https://mixxx.zulipchat.com/#narrow/stream/113295-controller-mapping/topic/Binding.20to.20whenever.20a.20Deck.20loads.20a.20new.20track

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Nov 6, 2018

I already updated the wiki with my changes as well.

Be-ing
Be-ing suggested changes Nov 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this and thanks for your patience.

There are lots of places throughout the code that are a bit hard to read because the code is squeezed together. Please use spaces around operators and after commas. Also, please break if statements and functions across multiple lines.

Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
Comment thread res/controllers/Numark-N4-4channel-scripts.js Outdated
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Nov 24, 2018

I notice the name of the XML file is "Numark N4 4channel.midi.xml", but the name of the controller is simply "Numark N4". Could you rename the XML file to overwrite the old mapping?

@mixxxdj mixxxdj deleted a comment Nov 24, 2018
@mixxxdj mixxxdj deleted a comment Nov 25, 2018
@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Nov 25, 2018

I have incorporated all requested changes from the review but I wasn't able to test the them yet as I don't have access to the controller right now. so DO NOT MERGE yet. I'll be able to test them tomorrow.

@mixxxdj mixxxdj deleted a comment Nov 25, 2018
Be-ing
Be-ing suggested changes Nov 25, 2018
View reviewed changes
Comment thread res/controllers/Numark-N4-scripts.js Outdated
Comment thread res/controllers/Numark-N4-scripts.js Outdated
@mixxxdj mixxxdj deleted a comment Nov 25, 2018
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Nov 25, 2018

Okay, leave a comment when you have tested the latest changes and it's ready for merge.

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Nov 26, 2018 •
edited
Loading

@Be-ing, The mapping is now finally ready to merge. I still have to update the Wiki with the latest tweaks but the script files are done.

@Be-ing Be-ing merged commit 1d4087a into mixxxdj:2.2 Nov 26, 2018
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Nov 26, 2018

Great, thanks!

@mixxxdj mixxxdj deleted a comment Nov 26, 2018
@Swiftb0y Swiftb0y mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Be-ing Be-ing Be-ing requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

controller mappings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Swiftb0y @Be-ing @rryan