Skip to content

fix library styles in 2.2#1867

Merged
Be-ing merged 4 commits intomixxxdj:2.2from
ronso0:2.2-lib-fixes
Oct 24, 2018
Merged

fix library styles in 2.2#1867
Be-ing merged 4 commits intomixxxdj:2.2from
ronso0:2.2-lib-fixes

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Oct 24, 2018

some labels and button borders in DlgRecording, DlgAutoDJ and DlgAnalysis were screwed up or offset.

Deere & Shade: adopt beatsize spinbox style for AutoDJ transition (I have the strange feeling I fixed this several times already...)
LateNight: add style for disabled buttons
Tango: make the scrollbars a bit wider

lib-fix_deere
lib-fix_shade
lib-fix_tango
lib-fix_latenight

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 24, 2018

LGTM with GNOME. Thanks for the polishing. :) It would be helpful to get a few more testers with different setups.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Oct 24, 2018

LGTM with GNOME. Thanks for the polishing. :) It would be helpful to get a few more testers with different setups.

Yup, it would be nice to have it confirmed it looks as above in Win/OSX as well!

@Be-ing Be-ing added this to the 2.2.0 milestone Oct 24, 2018
@benis
Copy link
Copy Markdown
Contributor

benis commented Oct 24, 2018

Looking good on macOS 10.13.6

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Oct 24, 2018

Thanks. Could we get someone to test on Windows? @JosepMaJAZ?

@JosepMaJAZ
Copy link
Copy Markdown
Contributor

Looking good here (heh.. I haven't used much the AutoDJ recently so I wasn't even aware of that... maybe I saw it but I didn't pay attention)

@Be-ing Be-ing merged commit d691edc into mixxxdj:2.2 Oct 24, 2018
@radusuciu
Copy link
Copy Markdown
Contributor

image
I think unrelated to changes here but saw this

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Oct 25, 2018

I think unrelated to changes here but saw this

Yes, unrelated. Your screenshot indicates there's another font used instead of Open Sans (which is included in Mixxx). I'll have a look.

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Oct 25, 2018

Should look like below. Note different letter spacing, also how C and S look like.
opensans
Which version and OS are you using?

@ronso0 ronso0 deleted the 2.2-lib-fixes branch October 25, 2018 13:54
@radusuciu
Copy link
Copy Markdown
Contributor

Windows 10, with the build artifact from this PR. I can install from stable and beta to see if issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants