Skip to content

fix "dataChanged() called with an invalid index range" warning #15937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daschuer merged 1 commit into from
Feb 3, 2026
Merged

fix "dataChanged() called with an invalid index range" warning #15937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/library/basesqltablemodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,13 +821,13 @@ void BaseSqlTableModel::tracksChanged(const QSet<TrackId>& trackIds) {
qDebug() << this << "trackChanged" << trackIds.size();
}

const int numColumns = columnCount();
const int lastColumn = columnCount() - 1;
for (const auto& trackId : trackIds) {
const auto rows = getTrackRows(trackId);
for (int row : rows) {
//qDebug() << "Row in this result set was updated. Signalling update. track:" << trackId << "row:" << row;
QModelIndex topLeft = index(row, 0);
QModelIndex bottomRight = index(row, numColumns);
QModelIndex bottomRight = index(row, lastColumn);
emit dataChanged(topLeft, bottomRight);
}
}
Expand Down