fix "dataChanged() called with an invalid index range" warning

[ronso0]

Closes #14610

This is a Qt warning that has been introduced in Qt6.9, see QAbstractItemView::dataChanged(topLeft, bottomRight, roles).
In earlier versions it just ignored the invalid range.

Note: regardless the Qt version it still calls viewport->update() which may try to update the entire view, depending on if model cache is enabled / how entensive it is (IIRC)
-> so this may also have been causing GUI issues while Analysis is running, see #15928 / #15930

The only Mixxx implementation that calls this base implementation is WLibraryTableView::dataChanged

if (!bottomRight.isValid()) {
    qWarning() << "bottomRight invalid, sender:" << sender();
}

reveals LibraryTableModel and AnalysisLibraryTableModel btw.

All emit dataChanged() signals we emit look good (topLeft & bottomRight created with reasonable numbers).
Except BaseSqlTableModel::tracksChanged where we are +1 outside the valid column range, hence index() returns an invalid index.

[daschuer]

LGTM. Great you have found it. Thank you very much.

[wimstefan]

Thank you so much for fixing this log-filling bug!
Will that be merged into main as well?

[ronso0]

Will that be merged into main as well?

Yes, all branches are merged "upwards" frequetly, like 2.5 -> 2.6, 2.6 -> main

[wimstefan]

Yes I noticed that it eventually got merged into main ...
I guess I simply was a bit too impatient 😁