Debian free fix#15895
Conversation
…onts-ubuntu-title issue mixxxdj#15816
github-actions
Bot
added
library
ui
preferences
packaging
developer experience
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
Cool, we are almost there. Thanks.
| echo "" | ||
| read -p "Do you want to enable the non-free repository and install fonts-ubuntu? (y/n) " -n 1 -r | ||
| echo | ||
| if [[ $REPLY =~ ^[Yy]$ ]]; then | ||
| echo "Enabling non-free repository..." | ||
| # Add non-free to sources.list if not already present | ||
| if ! grep -q " non-free$" /etc/apt/sources.list; then | ||
| sudo sed -i 's/^\(deb.*\) \(main\|contrib\|non-free-firmware\)$/\1 \2 non-free/' /etc/apt/sources.list | ||
| fi | ||
| echo "Updating package list..." | ||
| sudo apt-get update | ||
| FONTS_UBUNTU_AVAILABLE=true |
There was a problem hiding this comment.
messing with the sources sources.list feels risky. I don't want to be blamed for destroying users system because of a non standard sources.list file. How about this.
| echo "" | |
| read -p "Do you want to enable the non-free repository and install fonts-ubuntu? (y/n) " -n 1 -r | |
| echo | |
| if [[ $REPLY =~ ^[Yy]$ ]]; then | |
| echo "Enabling non-free repository..." | |
| # Add non-free to sources.list if not already present | |
| if ! grep -q " non-free$" /etc/apt/sources.list; then | |
| sudo sed -i 's/^\(deb.*\) \(main\|contrib\|non-free-firmware\)$/\1 \2 non-free/' /etc/apt/sources.list | |
| fi | |
| echo "Updating package list..." | |
| sudo apt-get update | |
| FONTS_UBUNTU_AVAILABLE=true | |
| echo "See also: https://wiki.debian.org/SourcesList" | |
| echo "" | |
| read -p "Would you like to exit to enable 'non-free' now? (y = Exit / n = Continue without fonts): " -n 1 -r | |
| echo | |
| if [[ $REPLY =~ ^[Yy]$ ]]; then | |
| echo "Please edit your /etc/apt/sources.list, run 'sudo apt update', and restart this script." | |
| exit 1 |
|
Done! |
|
Hi, this the third PR you are opening to fix
This will reduce the spam to the community. |
|
Done! One question, can I delete debian_free_fix in my local branch? if I do that will delete the commit or not? |
|
Thanks!
If you mean your fork (with a |
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
LGTM, Thank you for this nice starter PR.
|
@blackhold I like to put your name into the contributor list in the Mixxx about box. |
|
Lately I'm using my real name Laura Mora but Blackhold is easy to follow, so, if it's possible: Laura Mora (Blackhold). Thanks :) I have pending to continue the stems development, I'm ending some other work jobs, when I finish them I'll continue! |
|
You are always welcome, as your time allows. |
3 participants
Fixing debian_buildenv.sh file.