debian_buildenv.sh dependencies#15826
Conversation
daschuer
left a comment
There was a problem hiding this comment.
I am afraid this is not a solution. fonts-ubuntu-title comes with ubuntu-title, but MIxxx uses ubuntu (without any extension).
The Debian 13 package can be found here:
https://packages.debian.org/search?keywords=fonts-ubuntu&searchon=names&suite=trixie§ion=all
I think the issue happens because it us in the non-free area for some reasons.
But since this was an issue for you, we need to improve the situation.
How about adding a
apt-cache show fonts-ubuntu
Check and if it fails prompt the user to enable non-free or optional skip non free-packages.
|
The issue happens already in 2.5. Can you rebase your branch to 2.5? |
|
The installation is in a new fresh debian 13 install with official netinstaller iso from saturday: |
|
Greate. What does: Than follow this: https://serverfault.com/questions/240920/how-do-i-enable-non-free-packages-on-debian and try again. A solution would be to call and if it fails prompt the user to add the non-free repository, or ignore the error. |
|
I don't want to generate controversy, but you are forcing the user to add and use non-free packages to use a font, is that optimal? In case they want to use this package, the user should be informed that the non-free repository, and then add it to the script. |
|
Its a design decision of Mixxx to use the Ubuntu font. |
|
Well, this suffering in me is relative :P But there may be purist users who may back down. I consider that giving the user the option to use free or non-free repositories can be a point in favor of mixxx. It can be done in two ways, either by warning the user or creating a second script with the non-free option. The other option is to add a check of whether the package is available or not and solve it with an if. If you think it's good, I could implement it, I don't see anything excessively complicated. In my installation when making this change I haven't seen problems with this typography. Tell me where this typography is being used and I'll take a screenshot to see if it looks bad or not. |
|
The Debian distribution of Mixxx does not depend on any fonts. They have probably ripped of them because of the non free topic. For this PR I prefer a warning when "fonts-ubuntu" is missing for the 2.5 and 26 branch. The other question if there a fully free replacement for "fonts-ubuntu". I think it is used in the preferences. Since I am at Ubuntu I can't tell if it is explicit Ubuntu or just the default Ubuntu Font. This would be a 2.7 issue (main) |
|
OK, in next hours I add the message and the action and do the commit. |
|
well, changes applied to my branch, but I'm not able to create the pull request. The one thing I was able to do is: blackhold#1 UPDATE: oops! it seems it appears here! waiting to see if I have done the pull request ok. Thanks |
daschuer
left a comment
There was a problem hiding this comment.
Thank you for the nice addition.
This already suites to our 2.5 branch. Are you familiar with git? Can you rebase your solution to the 2.5 branch? If not, I can either guide you through the required commands for the sake of learning or take over after this PR is finished.
| # Check if fonts-ubuntu is available (from non-free repository) | ||
| if ! apt-cache show fonts-ubuntu 2>/dev/null | grep -q "Package: fonts-ubuntu"; then | ||
| echo "" | ||
| echo "⚠️ WARNING: The package 'fonts-ubuntu' is not available." |
There was a problem hiding this comment.
We do not use such an eye candy yet:
| echo "⚠️ WARNING: The package 'fonts-ubuntu' is not available." | |
| echo "WARNING: The package 'fonts-ubuntu' is not available." |
| echo "⚠️ WARNING: The package 'fonts-ubuntu' is not available." | ||
| echo "This package is required for Mixxx and is located in the Debian non-free repository." | ||
| echo "" | ||
| read -p "Do you want to enable the non-free repository and install fonts-ubuntu? (y/n) " -n 1 -r |
There was a problem hiding this comment.
Changing the users system like that makes me nervous. This may work now but may break any system that is no longe like we expect.
Can you replace that with a brief hint how to fix the situation, like linking to the official Debian Wiki https://wiki.debian.org/SourcesList and than just ask here if the user wants to continue anyway or recall the script later.
Done. In my repo I edited the file directly in main. |
|
Ah I see. Normally every PR should have a feature branch since you opened this PR on the 2.5 branch we can temporary treat your 2.6 branch as feature branch and reset it later to the 2.6 upstream branch. This is by the way a lovely tutorial for git. This helps me a lot: Now lets clean up this. I have already changed that merge target to 2.5, the reason we esse here 1623 commit. We want the single commit from main to be on top of 2.5. Now we can make your locals 2.6 branch a 2.5 branch. The following command than pick the n commits from main. Update this PR Unfortunately your edits regarding my comments are not yet online. Do yo plan to do it? |
|
close. Use #15895 |
debian_buildenv.sh it asks to install fonts-ubuntu but it should be fonts-ubuntu-title issue #15816