Skip to content

[Deere] Performance fix - Switch from SVG to PNG for VuMeters , tweak <PeakHoldTime> value #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Be-ing merged 3 commits into from
Apr 3, 2018
Merged

[Deere] Performance fix - Switch from SVG to PNG for VuMeters , tweak <PeakHoldTime> value #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a0e61f
Deere: Switch vumeter images from SVG to PNG. This works around lags …
esbrandt Apr 3, 2018
28cfd22
Lower the vumeter <PeakHoldTime> value, which is expensive. Make all …
esbrandt Apr 3, 2018
32af1a3
Deere: Fix error in sampler row selection button ``<PushButton>: WPus…
esbrandt Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions res/skins/Deere/sampler_rows_selection_button.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<ObjectName><Variable name="ObjectName"/></ObjectName>
<Size>80me,20f</Size>
<NumberStates>1</NumberStates>
<RightClickIsPushButton>true</RightClickIsPushButton>
<State>
<Number>0</Number>
<Text>[<Variable name="current"/>] Rows</Text>
Expand Down
Binary file added res/skins/Deere/vumeter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions res/skins/Deere/vumeter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
<TooltipId><Variable name="TooltipId"/></TooltipId>
<MinimumSize>50,5</MinimumSize>
<MaximumSize>200,5</MaximumSize>
<PathVu>vumeter.svg</PathVu>
<PathVu>vumeter.png</PathVu>
<Horizontal>true</Horizontal>
<PeakHoldSize>5</PeakHoldSize>
<PeakHoldTime>600</PeakHoldTime>
<PeakFallTime>100</PeakFallTime>
<PeakHoldTime>300</PeakHoldTime>
<PeakFallTime>20</PeakFallTime>
<PeakFallStep>1</PeakFallStep>
<Connection>
<ConfigKey><Variable name="group"/>,<Variable name="control"/></ConfigKey>
Expand Down
Binary file added res/skins/Deere/vumeter_clip.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions res/skins/Deere/vumeter_h.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
<TooltipId><Variable name="tooltip_meter"/></TooltipId>
<Size>9me,3me</Size>
<MaximumSize>80,8</MaximumSize>
<PathVu scalemode="STRETCH">vumeter.svg</PathVu>
<PathVu scalemode="STRETCH">vumeter.png</PathVu>
<Horizontal>true</Horizontal>
<PeakHoldSize>5</PeakHoldSize>
<PeakHoldTime>600</PeakHoldTime>
<PeakFallTime>100</PeakFallTime>
<PeakHoldTime>300</PeakHoldTime>
<PeakFallTime>20</PeakFallTime>
<PeakFallStep>1</PeakFallStep>
<Connection>
<ConfigKey><Variable name="group"/>,VuMeter<Variable name="side"/></ConfigKey>
Expand All @@ -33,7 +33,7 @@
<TooltipId><Variable name="tooltip_clip"/></TooltipId>
<Size>3min,3me</Size>
<MaximumSize>8,8</MaximumSize>
<PathStatusLight scalemode="STRETCH">vumeter_clip.svg</PathStatusLight>
<PathStatusLight scalemode="STRETCH">vumeter_clip.png</PathStatusLight>
<Connection>
<ConfigKey><Variable name="group"/>,PeakIndicator<Variable name="side"/></ConfigKey>
</Connection>
Expand Down
Binary file added res/skins/Deere/vumeter_latency.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions res/skins/Deere/vumeter_latency.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
<TooltipId><Variable name="TooltipId"/></TooltipId>
<MinimumSize>50,5</MinimumSize>
<MaximumSize>50,5</MaximumSize>
<PathVu>vumeter_latency.svg</PathVu>
<PathVu>vumeter_latency.png</PathVu>
<Horizontal>true</Horizontal>
<PeakHoldSize>5</PeakHoldSize>
<PeakHoldTime>1000</PeakHoldTime>
<PeakFallTime>100</PeakFallTime>
<PeakHoldTime>300</PeakHoldTime>
<PeakFallTime>20</PeakFallTime>
<PeakFallStep>1</PeakFallStep>
<Connection>
<ConfigKey><Variable name="group"/>,<Variable name="control"/></ConfigKey>
Expand Down
Binary file added res/skins/Deere/vumeter_v.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 7 additions & 7 deletions res/skins/Deere/vumeter_v.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ObjectName>PeakIndicator</ObjectName>
<TooltipId><Variable name="tooltip_clip"/></TooltipId>
<Size>8f,8f</Size>
<PathStatusLight scalemode="STRETCH">vumeter_clip.svg</PathStatusLight>
<PathStatusLight scalemode="STRETCH">vumeter_clip.png</PathStatusLight>
<Connection>
<ConfigKey><Variable name="group"/>,PeakIndicator<Variable name="side"/></ConfigKey>
</Connection>
Expand All @@ -36,11 +36,11 @@
<Size>3me,me</Size>
<MinimumSize>8,40</MinimumSize>
<MaximumSize>8,-1</MaximumSize>
<PathVu scalemode="STRETCH">vumeter_v.svg</PathVu>
<PathVu scalemode="STRETCH">vumeter_v.png</PathVu>
<Horizontal>false</Horizontal>
<PeakHoldSize>5</PeakHoldSize>
<PeakHoldTime>600</PeakHoldTime>
<PeakFallTime>100</PeakFallTime>
<PeakHoldTime>300</PeakHoldTime>
<PeakFallTime>20</PeakFallTime>
<PeakFallStep>1</PeakFallStep>
<Connection>
<ConfigKey><Variable name="group"/>,VuMeter<Variable name="side"/></ConfigKey>
Expand All @@ -64,11 +64,11 @@
<Size>3me,me</Size>
<MinimumSize>8,60</MinimumSize>
<MaximumSize>8,-1</MaximumSize>
<PathVu scalemode="STRETCH">vumeter_v.svg</PathVu>
<PathVu scalemode="STRETCH">vumeter_v.png</PathVu>
<Horizontal>false</Horizontal>
<PeakHoldSize>5</PeakHoldSize>
<PeakHoldTime>600</PeakHoldTime>
<PeakFallTime>100</PeakFallTime>
<PeakHoldTime>300</PeakHoldTime>
<PeakFallTime>20</PeakFallTime>
<PeakFallStep>1</PeakFallStep>
<Connection>
<ConfigKey><Variable name="group"/>,VuMeter<Variable name="side"/></ConfigKey>
Expand Down