Skip to content

fix: don't override unstable version with the current alpha#15361

Merged
JoergAtGithub merged 1 commit into
mixxxdj:mainfrom
acolombier:fix/skip-version-override-for-unstable
Nov 22, 2025
Merged

fix: don't override unstable version with the current alpha#15361
JoergAtGithub merged 1 commit into
mixxxdj:mainfrom
acolombier:fix/skip-version-override-for-unstable

Conversation

@acolombier
Copy link
Copy Markdown
Member

Fixup of #15214

@acolombier acolombier added the qml label Sep 14, 2025
@acolombier acolombier added this to the 3.0-beta milestone Sep 14, 2025
@github-project-automation github-project-automation Bot moved this to In progress in QML GUI Sep 14, 2025
@acolombier acolombier force-pushed the fix/skip-version-override-for-unstable branch from d31c937 to b2b3f4c Compare September 14, 2025 17:28
@acolombier acolombier force-pushed the fix/skip-version-override-for-unstable branch from b2b3f4c to 5c969fc Compare September 14, 2025 17:55
@acolombier
Copy link
Copy Markdown
Member Author

This bug is quite annoying, could I please get a review @mixxxdj/developers ?

@ywwg
Copy link
Copy Markdown
Member

ywwg commented Oct 22, 2025

I am lacking context, what is the difference between unstable and clean and alpha, and what bug is this fixing?

@acolombier
Copy link
Copy Markdown
Member Author

The config holds the last version Mixxx was running for, but the safety mechanism to prevent running the unstable 3.0 relies on this value to decide whether there is an existing stable config. This fix makes sure not to overwrite that value if running the unstable preview.

@JoergAtGithub
Copy link
Copy Markdown
Member

LGTM! Thank you!
I agree with @ywwg that a bit more context would've helped to understand what this PR fixes.

@JoergAtGithub JoergAtGithub merged commit a987f66 into mixxxdj:main Nov 22, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in QML GUI Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants