feat(QML): add checks to ensure user run with a dedicated test profile#15214
Conversation
eef1177 to
18a69a0
Compare
Swiftb0y
left a comment
There was a problem hiding this comment.
I really don't think this is super necessary, but I wasn't in the meeting this was agreed upon, so LGTM I guess?
To give some context, we've noticed some user are keen to try the QML instance as we are progressing, but the risk on corrupting existing user profile is large, since we are committing on a fast iterative set of many big changes for 3.0 (as opposite to a few small carefully measured and tested changes in 2.x). |
|
Yeah, I would've just been even more blunt with it and put no protections in place. IMO If a user is using a pre-alpha version, they are lucky they don't accidentally get their harddrive reformatted 😜 |
|
I agree with you! But you need to remember that we are developing 3.0 in place, meaning that somebody installing |
ywwg
left a comment
There was a problem hiding this comment.
Just a couple of wording comments. I have not QAed the actual flow
18a69a0 to
82cd64b
Compare
|
Thanks @ywwg - I amended the commit |
|
LGTM! Thank you! |
This PR adds the safety mechanism we discussed during the monthly catchup.
It will prevent user from running the highly unstable QML interface, and allow us to continue with the fast iteration.
Here is the expected behaviour when running on QML:
In the case no 3, a log message and a key will be persisted in the user profile, which might be helpful to track future issues report on
2.x, tho user can easily remove it.