LateNight 2.1 :. part II

[ronso0]

This PR fixes some minor issues and continues to reduces vertical space requirements.
It's WIP and I'll let it grow for a week or so. Maybe we can even introduce FX unit 3/4 and more samplers here

Reducing samplers height:

[ywwg]

very nice, no comments from me just looking at the screenshot (except that I miss the instant loop buttons for quick rolls, but those disappeared a while ago)

[ywwg]

hm, it does look like there are some spacing issues with the loop buttons though. The box for the loop size seems wider than it needs to be and it's cramming the adjustment buttons

[ronso0]

update

[ronso0]

(except that I miss the instant loop buttons for quick rolls, but those disappeared a while ago)

Yeah missed them , too, so I brought them back in Tango a while ago. There it's optional though..
At least for least for quick rolls I'd say we should bring'em back here as well

[ronso0]

The up/down buttons of beatsize spinboxes are fixed.
The overlapping is intented: 1) group spinbox & up/down buttons 2) text alignment in spinboxes is not working 100% correctly. Sometimes manually set loops(izes) with decimals may be shifted in a way that only the decimals are visible but everything in front of the point is truncated. Rare case, though
Looking better now?

[nopeppermint]

mixer is a little bit higher than the two decks, couldn't you shift up the crossfader a little bit?

[ronso0]

mixer is a little bit higher than the two decks, couldn't you shift up the crossfader a little bit?

@nopeppermint
No, the mixer is already a good compromise of compact & quickly readable & enough space to be sure you hit the right spot with the mouse. It's just the decks that have bigger margin to the elements below, a nice gap that allows for quick orientation. That's one aspect of LateNight I'd like to keep. You'll notice when you hide the mixer.
Maybe we also need to increase the other gaps, in between Samplers, FxUnits etc.

[nopeppermint]

• on Linux Mint there are some issues with the Text under the Knobs
  

• and Gain in 4 Deck mode
  

• BTW I suggest to use a smaller font size for the sampler Title

[ronso0]

There are still font issues, thanks for the hint!
I consider including a font for LateNight, so we don't run into trouble again (like you did) when a system doesn't have the fonts it was originally designed with.

[nopeppermint]

@ronso0 nice, it looks like font issue are now gone (Linux Mint x64, Cinnamon 3.6.3)

but also the Play/Pause button in Preview is gone..
It was like this before:

In the first screenshot there is no longer a Play/Pause Button in Preview..

that's a Button I use a lot !
I would like to have this button back

[ronso0]

whoopsie.. Preview deck shared sampler's Play button graphics, which I removed with the last commit.
fixed.

[ronso0]

@Be-ing @daschuer @ywwg
I'd like to get this merged asap so beta users can enjoy and test it.
Then we can fix remaining font issues and design a solution for advanced skin options (8 HotCues, mixer config, 4 FX units etc.) in another PR.

before

after

[ronso0]

It seems I also committed changes to HotCue graphics by mistake.
Will revert that asap

[ywwg]

looking great! No more notes from me

[daschuer]

Is it intended to have capitals only in the title and artist fields?

[ronso0]

Don't ask me..it was like that.
But I will change the sampler title a bit. Now both title & artist are uppersçase

[naught101]

into artist/duration row? might get tight there when playing "DJ Awesome ft. Incredible MC and his brother"

Truncating that would be fine. The full artist/guests name is rarely relevant anyway, you just need enough info to know that it's not that other track by that other artist with the same track name..

Any ideas where to put the beatgrid buttons? They're only useful when the waveform is visible, too, and the decks are already pretty crammed. Any objections against putting them into a container next to the waveforms, like in Tango? Maybe expandable..

Yeah, a container next to the main waveform display would make sense. (BTW, the tango ones are a bit broken: when shown, the "hide" button half covers the "adjust beats later" button).

[ronso0]

I'm not 100% fine with putting the stars next to the Artist, but I'll do it since there's no other opinion poppin up, and the other solutions require more reworking.

Last ToDos here:
- stars next to Artist
- adapt Tango beatgrid buttons

Edit I prefer to merge this now, and tackle the GUI changes in the next PR, as well, before this PR grows too much.

[ronso0]

BTW, the tango ones are a bit broken: when shown, the "hide" button half covers the "adjust beats later" button

Already fixed in #1473 Give it a shot if you like!

[ronso0]

Looking good? Ready to merge?

[daschuer]

Yes.

[daschuer]

Thank you, for all the love!