(fix) Browse feature: enable sorting#14688
Merged
Merged
Conversation
Member
|
@ronso0 doesn't build... so not very mergeable atm. |
Member
Author
Member
Author
|
Must admit the change set seems big, but it's just a part of already merged #13392, so I hope we can get this small usability fix into 2.5.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was there a reason to not enable it?
I didn't notice any issue with this. When a directory is loaded, and it's not sorted by filename, it gets resorted dynamically, ie. rows are inserted in between existing ones. That's the only aspect that might cause confusion, but the lazy loading (uncached) is not convenient anyways with many tracks.
edit: it's enabled in Recording (also using the BrowseTableModel), so I think it was only forgotten to enable it in Computer as well.