Skip to content

add Shuffle action to track table header menu#13392

Merged
acolombier merged 3 commits into
mixxxdj:mainfrom
ronso0:sort-random
Feb 21, 2025
Merged

add Shuffle action to track table header menu#13392
acolombier merged 3 commits into
mixxxdj:mainfrom
ronso0:sort-random

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Jun 20, 2024

image

Related bug is #12617 (fixed IMO, even though I mentioned #8521 there)

I also tried to set a Shuffle icon, but aligning that with the column checkboxes is a PITA. Will stash my attempt and try again later on.

@github-actions
Copy link
Copy Markdown

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Sep 19, 2024
@ronso0 ronso0 removed skins autodj stale Stale issues that haven't been updated for a long time. labels Sep 19, 2024
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Sep 19, 2024

I also tried to set a Shuffle icon, but aligning that with the column checkboxes is a PITA.

I'll try again by making Shuffle QWidgetAction with QCheckBox, like the other actions.
Though that is nice to have (can be happen in a followup) and shouldn't hold up this PR.

@acolombier
Copy link
Copy Markdown
Member

A conflict has developed here, otherwise I think this is pretty much to go!

Copy link
Copy Markdown
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested and work as expected, thanks!

@acolombier acolombier merged commit 2e91593 into mixxxdj:main Feb 21, 2025
@ronso0 ronso0 deleted the sort-random branch February 21, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move hidden Randomize feature from Preview column to track table header

2 participants