fix Windows build#1437
Merged
daschuer merged 2 commits intomixxxdj:masterfrom Dec 23, 2017
Merged
Conversation
Contributor
Author
|
Okay, the compile error with ratecontrol.cpp is fixed. The build is failing for an unrelated reason which has been affecting lots of AppVeyor builds seemingly randomly: |
Member
|
no, the build is failing because of line 7274-7279 of the log |
Contributor
Author
|
Ack, thanks for pointing that out. |
Member
|
you should be interested in #1440 |
Contributor
Author
|
Okay, AppVeyor build is working with this. EngineBufferE2ETest.KeylockReverseTest is failing, which I have already fixed in #1254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like #1377 broke the Windows build. We urgently need reliable CI!!