Skip to content

fix Windows build#1437

Merged
daschuer merged 2 commits intomixxxdj:masterfrom
Be-ing:windows_build_fix
Dec 23, 2017
Merged

fix Windows build#1437
daschuer merged 2 commits intomixxxdj:masterfrom
Be-ing:windows_build_fix

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Dec 22, 2017

Looks like #1377 broke the Windows build. We urgently need reliable CI!!

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Dec 22, 2017

Okay, the compile error with ratecontrol.cpp is fixed. The build is failing for an unrelated reason which has been affecting lots of AppVeyor builds seemingly randomly:
LINK : fatal error LNK1181: cannot open input file 'vamp-sdk.lib'

@Be-ing Be-ing changed the title attempt to fix Windows build fix Windows build Dec 22, 2017
@Be-ing Be-ing mentioned this pull request Dec 22, 2017
8 tasks
@sblaisot
Copy link
Copy Markdown
Member

no, the build is failing because of

[CXX] src\preferences\dialog\dlgprefdeck.cpp
dlgprefdeck.cpp
src\preferences\dialog\dlgprefdeck.cpp(459): error C2440: 'static_cast': cannot convert from 'double' to 'TrackTime::DisplayMode'
src\preferences\dialog\dlgprefdeck.cpp(459): note: Conversions between enumeration and floating point values are no longer allowed
scons: *** [win64_build\preferences\dialog\dlgprefdeck.obj] Error 2
scons: building terminated because of errors.

line 7274-7279 of the log

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Dec 22, 2017

Ack, thanks for pointing that out.

@sblaisot
Copy link
Copy Markdown
Member

you should be interested in #1440

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Dec 22, 2017

Okay, AppVeyor build is working with this. EngineBufferE2ETest.KeylockReverseTest is failing, which I have already fixed in #1254

@daschuer daschuer merged commit 6e3628e into mixxxdj:master Dec 23, 2017
@Be-ing Be-ing deleted the windows_build_fix branch December 29, 2017 16:22
@Be-ing Be-ing added this to the 2.1.0 milestone Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants