Skip to content

remove persistence from EffectUnit routing switches#1385

Closed
Be-ing wants to merge 1 commit intomixxxdj:masterfrom
Be-ing:effectunit_routing_not_persistent
Closed

remove persistence from EffectUnit routing switches#1385
Be-ing wants to merge 1 commit intomixxxdj:masterfrom
Be-ing:effectunit_routing_not_persistent

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Nov 20, 2017

I thought this would be useful before when I worked on #1103, but experience has shown it is annoying. I want effect unit 1 assigned to deck 2, unit 2 to deck 2, unit 3 to deck 3, and unit 4 to deck 4 on startup regardless of how the routing switches happened to be when I last shut down Mixxx.

I thought this would be useful before when working on mixxxdj#1103, but
experience has shown it is annoying. I want effect unit 1
assigned to deck 1, unit 2 to deck 2, unit 3 to deck 3,
and unit 4 to deck 4 on startup regardless of how the routing
switches happened to be when I last shut down Mixxx.
@daschuer
Copy link
Copy Markdown
Member

Can we make this optional. If we think on the broadcasting use case, where mic and master effects are needed, it could be annoying to adjust the routing on every startup.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Nov 20, 2017

I'm mostly using 2 decks and I try to work with two different effect chains for each deck, which is now easy to handle with components-js. It would be nice if the assignment would persist after restart. Also, assignment is easy to see and to change with the in-deck FX buttons you suggested.

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 21, 2017

Hmm, a preference option may be warranted then. I'll return to this after #1377 is merged.

@JosepMaJAZ
Copy link
Copy Markdown
Contributor

Talking about persistence...
I do not find it annyoing that the routing is persisted (Although it's reasonable to have the option to reset them on startup too), but what I do find annoying is to have to reenable the effects inside the effect unit each time.
My mapping currently controls the routing, and I don't have individual effect buttons on my controller. I could change the setup to control two effects on each effectrack, but then I would need the routing to be persisted.

@Be-ing Be-ing closed this Dec 15, 2017
@ronso0 ronso0 mentioned this pull request Dec 28, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants