Fix default tooltip settings, when mixxx.cfg is empty, fixes Bug #118933...

[daschuer]

...7

[ywwg]

Where does this "1" come from? I guess the tooltips config item is dependent on the index number of the menu item? That seems bad.

[daschuer]

mixxx.h Line 230:
int m_tooltips; //0=OFF, 1=ON, 2=ON (only in Library)

But we should replace this by an enum.

[ywwg]

yeah if you're touching this code anyway, we might as well make it an enum. If the enum is numbered the same way as preexisting behavior then we don't even need to worry about migration.

[daschuer]

yeah if you're touching this code anyway, we might as well make it an enum. If the enum is
numbered the same way as preexisting behavior then we don't even need to worry about migration.

Arrg.. :-/ In C++ enums cannot be converted to int. So we must stay with int to avoid to much work.
But I have added comments, and a little refactoring.

[ywwg]

sure they can, you use a switch/case block. It is sad, but them's the breaks.

static int MyEnumToInt(Enum killmenow) {
  switch(killmenow) {
  case Enum::firstone:
    return 0;
  default:
    ErrorCondition();
  }
}

The reason this is not so horrendous is you are forced to do error checking.

[daschuer]

Yes, I know, but IMHO the extra work is not worth here. It is just a bug fix.
We have to deal with the integer anyway, when converting to the combo box index and we will find it in the mixxx.cfg file.

[rryan]

You can also static_cast() enums which is less verbose but doesn't have error handling.

enum FooEnum {
    FOO = 0,
    BAR,
    BAZ
}
FooEnum bar = BAR;
int iBar = static_cast<int>(bar);

iBar will have the value 1.

[rryan]

But I agree... no need to do a bunch of work just to fix a bug. LGTM to me.