fix: set ACCOUNT_MICROFRONTEND_URL default to empty string - #3288
Merged
arslanashraf7 merged 1 commit intoJun 12, 2025
Conversation
feoh
self-requested a review
June 12, 2025 13:35
feoh
approved these changes
Jun 12, 2025
asadali145
pushed a commit
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/7549
Description (What does it do?)
Sets a default value for
ACCOUNT_MICROFRONTEND_URLbecause it breaks because of a recent code change in https://github.com/openedx/edx-platform/pull/36870/files. The new implementation doesrstrip()onNoneand fails. It will not break on''.rstrip()Screenshots (if appropriate):
How can this be tested?
Additional Context