Use cache on build #9639
Merged
Use cache on build #9639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #9639 +/- ##
========================================
Coverage 22.62% 22.62%
========================================
Files 731 731
Lines 68487 68487
Branches 2028 2028
========================================
Hits 15495 15495
Misses 52992 52992 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
🙏🏻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #9614
Additional info (optional)
docker/build-push-action#716 と moby/buildkit#1512 が原因でGHAではdownload cacheが効かないのでcache-fromとcache-toでレイヤを再利用できるようにしている。
ローカルではレイヤキャッシュは勝手に処理してくれるはずだし、なにか事前情報が変わったとしてもaptとpnpmのdownload cacheを再利用できるようにしている。
注意点として、BuildKitの機能を利用しているのでSUSE系のビルダーツール(Podman, Buildah)では動かないかもしれない。(kanikoは勝手に無視してくれたっぽい)