updated all imports for miragejs objects to be from miragejs #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Dec 1, 2021
| @@ -52,9 +52,9 @@ Say we wanted to test that when the user visits a details route for a movie titl | |||
|
|
|||
| ```js | |||
| // mirage/factories/movie.js | |||
| import Mirage from 'ember-cli-mirage'; | |||
| import Factory from 'ember-cli-mirage'; | |||
There was a problem hiding this comment.
@cah-briangantzler should this be import { Factory } from 'miragejs';?
There was a problem hiding this comment.
Yep. Fixed it. Though IMO Most the of the Docs like this need removed. Ember-cli-mirage is no longer of the source of Factories. This same documentation exists in MirageJS. About 80% of the current Docs should be removed.
| @@ -1,6 +1,7 @@ | |||
| import { module, test } from 'qunit'; | |||
| import { setupTest } from 'ember-qunit'; | |||
| import {createServer, applyEmberDataSerializers} from 'ember-cli-mirage'; | |||
| import {createServer } from 'miragejs'; | |||
There was a problem hiding this comment.
@cah-briangantzler minor, missing space in {createServer }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally for tests and such ember-cli-mirage still imported all the miragejs objects from the re-exported ones in ember-cli-mirage instead of miragejs proper.
Updated them.