Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate miragejs re-exports from ember-cli-mirage module #2244

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

SergeAstapov
Copy link
Collaborator

@cah-briangantzler this is the dirty but seem to be working solution for re-exports deprecation.

@cah-brian-gantzler
Copy link
Collaborator

This works wonderfully. I googled for some time and was not able to find a way. Might want to write a blog post on this.

@cah-brian-gantzler cah-brian-gantzler merged commit a6023ee into miragejs:master Nov 30, 2021
@cah-brian-gantzler
Copy link
Collaborator

The docs say to import like this

import { Factory } from 'ember-cli-mirage';

Does anyone import like this?

import Factory from 'ember-cli-mirage/factory';

because this file supports that. https://github.com/miragejs/ember-cli-mirage/blob/master/addon/factory.js

There are a few others. May have to deprecate that as well.

@SergeAstapov
Copy link
Collaborator Author

@cah-briangantzler lot me take another look, will try to catch all the re-exports as they have to be deprecated

@SergeAstapov SergeAstapov deleted the deprecate-imports branch November 30, 2021 21:20
@cah-brian-gantzler
Copy link
Collaborator

Ironically ember-cli-mirage still imported the re-exports in its tests instead of mirage proper. Updated those if you want to take a look.

#2246

@SergeAstapov SergeAstapov changed the title Deprecate miragejs re-exports Deprecate miragejs re-exports from ember-cli-mirage module Dec 7, 2021
@SergeAstapov SergeAstapov changed the title Deprecate miragejs re-exports from ember-cli-mirage module Deprecate miragejs re-exports from ember-cli-mirage module Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants