Attempt at getting rid of json parsing in favour of jsonm #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing the quotations now... |
undoing overzealous deletion
|
OK this branch seems to work now... |
samoht
added a commit
that referenced
this pull request
Jan 29, 2014
Attempt at getting rid of json parsing in favour of jsonm
|
Thanks! |
|
This never got released... sorting it out now in #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds and passes the tests for me. Would like some feedback about whether the interface should change to match ezjsonm's. Ezjsonm uses
from_stringinstead ofof_stringfor exampleAlso, Is the build system rocket science necessary? I just banged my head on it until it worked but I'm not sure that I correctly edited it