Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Interface Too Simplified #44

Open
dsheets opened this issue Feb 10, 2014 · 5 comments
Open

Markdown Interface Too Simplified #44

dsheets opened this issue Feb 10, 2014 · 5 comments

Comments

@dsheets
Copy link
Member

dsheets commented Feb 10, 2014

Since abf78d5 and the switch to omd, the cow markdown interface has been too simple to support existing library users, e.g. opam2web.

Markdown.t is aliased to Html.t which destroys the markdown structure and makes Markdown.to_string lie (or at least hire a lawyer). Because the md AST isn't available, one can't use a Markdown.t to generate a ToC (and the Cow ToC function has now disappeared). To get the basic old features of Cow.Markdown, one now has to add omd as a dependency.

The present design means that Cow can't easily offer multiple HTML serializations of the same markdown which seems rather odd.

Perhaps this was all intended. It just seems odd (and slightly pointless) to me.

@samoht
Copy link
Member

samoht commented Feb 11, 2014

Agreed. Cow needs some love, please sends patches!

@avsm
Copy link
Member

avsm commented Feb 11, 2014

I have no beef with making this change.

On 11 Feb 2014, at 00:06, Thomas Gazagnaire [email protected] wrote:

Agreed. Cow needs some love, please sends patches!


Reply to this email directly or view it on GitHub.

@dsheets
Copy link
Member Author

dsheets commented Feb 11, 2014

Whatever change I make will break back compat and increment the version. For now, we will release opam2web 1.3.0 against cow 0.8.1 or earlier. Perhaps I will work on this in a few weeks.

@avsm
Copy link
Member

avsm commented Feb 11, 2014

That's fine, we can fix up any existing users. After Feb 27th :)

On 11 Feb 2014, at 00:26, David Sheets [email protected] wrote:

Whatever change I make will break back compat and increment the version. For now, we will release opam2web 1.3.0 against cow 0.8.1 or earlier. Perhaps I will work on this in a few weeks.


Reply to this email directly or view it on GitHub.

@mor1
Copy link
Member

mor1 commented Feb 11, 2014

@dsheets as i think my original commit indicated (and if it didn't, i did on the list and/or irc at the time), this was just a quick hack to get some reasonably standard markdown working as the old cow markdown parser was idiosyncratic (and iirc couldn't handle my pages).

feel free to shred it (either you or anyone else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants