-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Interface Too Simplified #44
Comments
Agreed. Cow needs some love, please sends patches! |
I have no beef with making this change. On 11 Feb 2014, at 00:06, Thomas Gazagnaire [email protected] wrote:
|
Whatever change I make will break back compat and increment the version. For now, we will release opam2web 1.3.0 against cow 0.8.1 or earlier. Perhaps I will work on this in a few weeks. |
That's fine, we can fix up any existing users. After Feb 27th :) On 11 Feb 2014, at 00:26, David Sheets [email protected] wrote:
|
@dsheets as i think my original commit indicated (and if it didn't, i did on the list and/or irc at the time), this was just a quick hack to get some reasonably standard markdown working as the old cow markdown parser was idiosyncratic (and iirc couldn't handle my pages). feel free to shred it (either you or anyone else :) |
Since abf78d5 and the switch to omd, the cow markdown interface has been too simple to support existing library users, e.g. opam2web.
Markdown.t
is aliased toHtml.t
which destroys the markdown structure and makesMarkdown.to_string
lie (or at least hire a lawyer). Because the md AST isn't available, one can't use aMarkdown.t
to generate a ToC (and the Cow ToC function has now disappeared). To get the basic old features ofCow.Markdown
, one now has to add omd as a dependency.The present design means that Cow can't easily offer multiple HTML serializations of the same markdown which seems rather odd.
Perhaps this was all intended. It just seems odd (and slightly pointless) to me.
The text was updated successfully, but these errors were encountered: