generate: add space to string_of_status#754
Merged
Merged
Conversation
This is required by the spec. The change could have gone into the response module, adding a specific logic checking the presence of the space before the string termination, but it seemed cleaner to add it here. Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Collaborator
Author
|
We can produce a better response with this change in response.ml: https://github.com/mseri/ocaml-cohttp/blob/15f6807b66c8ec1a1640ad7d24f0b05e4557591d/cohttp/src/response.ml#L107-L120 but it probably adds extra complexity for no reason. |
as suggested in the issue report Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Closed
samoht
approved these changes
Mar 15, 2021
avsm
approved these changes
Mar 15, 2021
Member
avsm
left a comment
avsm
left a comment
There was a problem hiding this comment.
The simpler one looks good to me -- no need to put extra bytes over the wire when the longer description can be looked up easily enough :-)
Just needs a CHANGES entry and good to merge.
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by the spec.
The change could have gone into the response module,
adding a specific logic checking the presence of the
space before the string termination, but it seemed
cleaner to add it here.
Should fix #752.
Signed-off-by: Marcello Seri marcello.seri@gmail.com