Skip to content

generate: add space to string_of_status #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mseri merged 3 commits into from
Mar 16, 2021
Merged

generate: add space to string_of_status #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c0e66c
generate: add space to string_of_status
mseri Mar 12, 2021
df7dfad
string_of_status: us better wording
mseri Mar 15, 2021
13d92bf
Update CHANGES file
mseri Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## current

- cohttp.response: fix malformed status header for custom status codes (@mseri @aalekseyev #752)
- Remove dependency to base (@samoht #745)
- fix opam files and dependencies
- add GitHub Actions workflow (@smorimoto #739)
Expand Down
5 changes: 4 additions & 1 deletion cohttp/scripts/generate.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,10 @@ let output_string_of_status oc ~mli s =
else (
append oc "let string_of_status: status_code -> string = function";
iter (fun c -> append oc " | %s -> \"%d %s\"" c.constr c.code c.descr) s;
append oc " | `Code cod -> string_of_int cod");
(* the response status must include an extra space even if no description is present, cf. #752 *)
append oc " | `Code cod ->";
append oc " let code = string_of_int cod in";
append oc " code ^ \" Status \" ^ code");
append oc ""

let output_reason_phrase_of_code oc ~mli s =
Expand Down