Skip to content

ppx_irmin: require ppxlib.0.15.0#1063

Closed
craigfe wants to merge 1 commit into
mirage:masterfrom
craigfe:upgrade-ppx
Closed

ppx_irmin: require ppxlib.0.15.0#1063
craigfe wants to merge 1 commit into
mirage:masterfrom
craigfe:upgrade-ppx

Conversation

@craigfe
Copy link
Copy Markdown
Member

@craigfe craigfe commented Aug 12, 2020

Ppxlib.0.15.0 drops a dependency on Base, allowing us to not explicitly depend on it. This fixes a bug picked up by Travis (see discussion).

@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 12, 2020

Looks like this isn't going to work, since e.g. the transitive dependency chain cohttpppx_sexp_convppxlib { < "0.15.0" } prevents us from using the latest Ppxlib 😢 I'll make a different PR to just implicitly depend on Base until that situation pans out.

@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Aug 12, 2020

Done in #1064.

@craigfe craigfe marked this pull request as draft August 17, 2020 08:07
Ppxlib.0.15.0 drops a dependency on Base
@craigfe craigfe added the no-changelog-needed No changelog is needed here label Sep 3, 2020
@craigfe
Copy link
Copy Markdown
Member Author

craigfe commented Sep 28, 2020

No longer necessary due to upstream fixes to ppx_sexp_conv.

@craigfe craigfe closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed No changelog is needed here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant