Remove caching of buffers#1060
Merged
Merged
Conversation
We are now caching the IO instances instead. Also, this could lead to tricky bugs when we start to rename file. This is similar to mirage/index@f8fdc93
craigfe
approved these changes
Aug 11, 2020
Member
Author
|
Travis fails with: which is a sensible error but unrelated to that PR so merging. |
Member
|
I'll make a PR to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now caching the IO instances instead. Also, this could lead
to tricky bugs when we start to rename files.
This is similar to mirage/index@f8fdc93