Skip to content

Remove caching of buffers#1060

Merged
samoht merged 1 commit into
mirage:masterfrom
samoht:do-not-cache-buffers
Aug 11, 2020
Merged

Remove caching of buffers#1060
samoht merged 1 commit into
mirage:masterfrom
samoht:do-not-cache-buffers

Conversation

@samoht
Copy link
Copy Markdown
Member

@samoht samoht commented Aug 11, 2020

We are now caching the IO instances instead. Also, this could lead
to tricky bugs when we start to rename files.

This is similar to mirage/index@f8fdc93

We are now caching the IO instances instead. Also, this could lead
to tricky bugs when we start to rename file.

This is similar to mirage/index@f8fdc93
@craigfe craigfe added the no-changelog-needed No changelog is needed here label Aug 11, 2020
@samoht
Copy link
Copy Markdown
Member Author

samoht commented Aug 11, 2020

Travis fails with:

#=== ERROR while compiling ppx_irmin.2.2.0 ====================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.09.1 | pinned(file:///repo)
# path                 ~/.opam/4.09/.opam-switch/build/ppx_irmin.2.2.0
# command              ~/.opam/4.09/bin/dune build -p ppx_irmin -j 71
# exit-code            1
# env-file             ~/.opam/log/ppx_irmin-5582-e7966f.env
# output-file          ~/.opam/log/ppx_irmin-5582-e7966f.out
### output ###
# File "src/ppx_irmin/deriver/dune", line 4, characters 33-37:
# 4 |  (libraries ppx_irmin_lib ppxlib base))
#                                      ^^^^
# Error: Library "base" not found.
# Hint: try: dune external-lib-deps --missing -p ppx_irmin -j 71 @install

which is a sensible error but unrelated to that PR so merging.

@samoht samoht merged commit 35d85e9 into mirage:master Aug 11, 2020
@samoht samoht deleted the do-not-cache-buffers branch August 11, 2020 12:37
@craigfe
Copy link
Copy Markdown
Member

craigfe commented Aug 11, 2020

I'll make a PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed No changelog is needed here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants