Skip to content

Remove caching of buffers #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samoht merged 1 commit into from
Aug 11, 2020
Merged

Remove caching of buffers #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/irmin-pack/IO.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,6 @@ module Unix : S = struct
t.flushed <- header;
Buffer.clear t.buf

let buffers = Hashtbl.create 256

let buffer file =
try Hashtbl.find buffers file
with Not_found ->
let buf = Buffer.create (4 * 1024) in
Hashtbl.add buffers file buf;
buf

let v ~fresh ~version:current_version ~readonly file =
assert (String.length current_version = 8);
let v ~offset ~version raw =
Expand All @@ -169,7 +160,7 @@ module Unix : S = struct
offset;
raw;
readonly;
buf = buffer file;
buf = Buffer.create (4 * 1024);
flushed = header ++ offset;
}
in
Expand Down