Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toX, mapContextInX added and more #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lue-bird
Copy link

@lue-bird lue-bird commented Sep 11, 2022

What's different from the existing open PR?

  • no embed functions
    • functionality is covered well enough by
      with (\context -> ... |> element)
    • ↑ is more generic, meaning it allows different
      msg, Option value etc. types and avoids ↓
  • no separate embed module
  • the run functions for which you considered exposing useful
    are called toX instead of unwrapX
  • withX, fromX functions for Element.WithContext.Input Label, Thumb, Option, Placeholder
    • providing the same functionality as for element, attribute
    • to embed elements with a different context type
  • mapContextInX functions for element, attribute, Element.WithContext.Input Label, Thumb, Option, Placeholder
  • more documentation
  • corrections to broken links, spelling and type variable names

To discuss

  • mapContextInX's name: maybe mapContextForX, xOverMappedContext, xOverContext, xOver, other suggestions very welcome!

@miniBill
Copy link
Owner

Thank you for the PR! I will try to have a look at it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants