-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing opaque type to type alias results in MAJOR bump #1895
Comments
Changing the custom type to a type alias essentially exposes a constructor to it, so it makes sense the way it is now. Recusing down the types to figure out if it's possible to actually construct that type alias is probably quite a lot of effort. |
In which case should this be a MINOR change, equivalent to adding a new function? |
I don’t believe this is true: the constructor is not exposed in either scenario. |
Gets changed to
where
Internal
is not in"exposed-modules"
. Conceptually, this doesn't change anything for the calling code of this package, as it is still the same type, just it's implementation details changed slightly (but being able to do that was the point of making it opaque in the first place). As such, this should be a PATCH change.However,
elm diff
gives:The text was updated successfully, but these errors were encountered: