refactor apply_inputs and support converting block for v2 compatibility #3409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
apply_inputs()
andvalidate_inputs()
to reduce duplicated code and simplify block conversion for future compatibility and v2 peer support.Extracted some relatively isolated changes from #3385.
utxo_view
is now "source of truth" for identifying outputs being spent by inputsutxo_view.validate_inputs()
to identify outputs being spentapply_inputs()
now usesutxo_view.validate_inputs()
internallyapply_inputs()
We need to hook block conversion into the block processing pipeline early on, but after orphan block identification.
This required some refactoring of
chain.process_block_single()
.Checking for orphan block is simplified with an explicit check for "previous block in db".
This is a relatively large PR but mainly refactoring with the addition of the "v2 block conversion" step (lookup features for each output being spent).
We have good test coverage of the block processing pipeline.
Testing this on mainnet also to ensure the node syncs and stays in sync.