-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v3 blocks and transactions (no redundant input features) #3385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
input_commitments
branch
3 times, most recently
from
July 24, 2020 09:24
e3e1a45
to
891ecb4
Compare
antiochp
changed the title
[WIP] Inputs commit only, no output features
[WIP] v3 blocks and transactions (no redundant input features)
Jul 24, 2020
This was referenced Jul 26, 2020
antiochp
force-pushed
the
input_commitments
branch
from
July 27, 2020 21:40
ba1d42f
to
c94752c
Compare
This was referenced Jul 28, 2020
Replaced with smaller more focused refactor PRs (various) and #3419. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
There is some complexity here as translating a v3 input to v2 requires "external" data (the output features). The output features must be read from the output MMR which must be in the correct state itself, based on current block being processed.
Additionally this messes with sort order as we sort based on hash and the data being hashed is different.
So converting v2->v3 and v3->v2 cannot be done purely on individual inputs.
It must be handled at the collection level as the collection of inputs must be reordered to account for the new sort order.
Resolves #3378.
TODO -
Inputs
enum variantsCommitOnly, FeaturesAndCommit
CommitWrapper
for sorting commitments correctly byhash()
v2
vs.v3
)