cleanup and simplify how we generate the genesis block in user_testing #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g (and automated_testing) modes
|
This affects only automated tests and user testing and these all still appear to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect some recent changes inadvertently broke "user testing" due to how we set the timestamp on the genesis block.
This PR simplifies genesis block creation in user testing. We just hard-code the timestamp now (we did before but at some point we started overwriting it with
now().We now also just hard-code the nonce to
0on both testing modes - it is fast to mine the dev genesis block in "user_testing" so just do that each time.To make this consistent we simply call
pow::mine_genesis_block()when setting up the genesis block during user testing.